Open
Conversation
Contributor
Author
Some units (primarily Vanleigh RVs) may not have a front Heat Pump or it may be moved to a new location in the coach
Collaborator
|
How does one select what layout they have? FYI I don't own a Tiffin (or a CoachProxy) any more so I'm reviewing/approving these based purely on the code -- I don't have a way to see the changes and test them myself. |
Contributor
Author
|
This would be adjusted via the normal settings screen via a Toggle, just as the Mid and Rear HP options are set |
Collaborator
|
Ah, I see it now in the |
Contributor
Author
|
I can do that, is it as simple as duplicating to the _base or is there differences between the two? I wasn't 100% sure on that :) |
Collaborator
|
It should be really close but I’m not sure if it’s 100% identical. It’s been a really long time since I’ve messed with it! If the surrounding json looks identical, then I guess we can assume the whole thing is identical :-)
… On Jul 6, 2021, at 8:55 PM, ODSMarcus ***@***.***> wrote:
I can do that, is it as simple as duplicating to the _base or is there differences between the two? I wasn't 100% sure on that :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Some units (primarily Vanleigh RVs) may not have a front Heat Pump or it may be moved to a new location in the coach. This allows for this functionality
Resolves #26